search

tonight123 / npapi-sdk

Automatically exported from code.google.com/p/npapi-sdk
0 stars 0 forks source link

add support for Asynchronous Drawing Models (Bitmap and Windows Accelerated) #20

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
https://wiki.mozilla.org/NPAPI:AsyncDrawing

Original issue reported on code.google.com by josh....@gmail.com on 25 Apr 2012 at 1:05

GoogleCodeExporter commented 9 years ago 
Stuart, can you review this?

Original comment by josh...@gmail.com on 25 Apr 2012 at 4:11

Attachments:

GoogleCodeExporter commented 9 years ago 
> -  NPDrawingModelCoreAnimation = 3,
> +  NPDrawingModelCoreAnimation = 3, /* DEPRECATED, DO NOT USE */

I disagree pretty strongly with this change; My understanding was that Safari 
never intends to support ICA (since they don't have the implementation 
constraints that make it problematic to support CA), and everyone was okay with 
that, so describing it as deprecated is actively misleading, and will confuse 
plugin vendors.

> +  NPDrawingModelAsyncBitmapSurface = 7,
> +#if defined(XP_WIN)
> +  NPDrawingModelAsyncWindowsDXGISurface = 8
...
> +  , NPNVsupportsAsyncBitmapSurfaceBool = 2005
> +#if defined(XP_WIN)
> +  , NPNVsupportsAsyncWindowsDXGISurfaceBool = 2006

Mismatching the numbers here seems like a very bad idea. I would like to see us 
use 2007 and 2008 here. Not only will this be less potentially confusing, but 
it makes it easy to add support variables for the original types later (just as 
we've needed to add a support variable for QD on the Mac). In fact, it seems 
like it wouldn't hurt to just go ahead and add them now, but I feel much less 
strongly about that than I do about aligning the numbers.

Original comment by stuart.morgan on 3 May 2012 at 2:09

GoogleCodeExporter commented 9 years ago

Original comment by stuart.morgan on 3 May 2012 at 2:09

GoogleCodeExporter commented 9 years ago 
I'm on board re: NPDrawingModelCoreAnimation - I'll drop that comment from the 
patch.

Original comment by josh....@gmail.com on 3 May 2012 at 3:52

GoogleCodeExporter commented 9 years ago 
Updated patch.

Original comment by josh....@gmail.com on 3 May 2012 at 4:08

Attachments:

GoogleCodeExporter commented 9 years ago 
LGTM, thanks.

Original comment by stuart.morgan on 3 May 2012 at 4:09

GoogleCodeExporter commented 9 years ago

Original comment by stuart.morgan on 14 Jan 2013 at 9:48