Add ButtonGroup - Githubissues

tonightpass / kitchn

@tonightpass delicious React @styled-components

https://kitchn.tonightpass.com

MIT License

47 stars 6 forks source link

Add ButtonGroup #54

Open jerembdn opened 1 year ago

jerembdn commented 1 year ago

Set the size and variant of all buttons within it.
Add spacing between the buttons.
Flush the buttons together by removing the border radius of their children as needed

AntoineKM commented 1 year ago

Add spacing between the buttons.

Container are fine for it.

The idea is good but it is still very complicated to implement and we may encounter some bugs, I lower the priority and put it on "low".

jerembdn commented 1 year ago

The goal of this group container is to assign the same props to every buttons within it like this, i think it could be great to have that feature, not only for tonightpass, but as a complete ui-kit.

<ButtonGroup variant='outline'>
  <Button color='blue'>Save</Button>
  <Button>Cancel</Button>
</ButtonGroup>

AntoineKM commented 5 months ago

https://chakra-ui.com/docs/components/button