search

tonik / theme

Tonik is a WordPress Starter Theme which aims to modernize, organize and enhance some aspects of WordPress theme development.
http://labs.tonik.pl/theme/
MIT License
1.33k stars 140 forks source link

Add/webpack 5 support #102

Open niklasp opened 3 years ago

niklasp commented 3 years ago

Now works with develop branch in tonik/cli

jedrzejchalubek commented 3 years ago

Oh my god! That is a horrific amount of work. Great, good work 👏

As this is way beyond standard update I would need to sit down and test it out on a few different projects. I will do this as soon as it will be possible 😄

Thanks!

niklasp commented 3 years ago

@jedrzejchalubek it works to the point where the scaffolding from tonik/cli comes in. It references old packages (e.g. bootstrap-sass instead of bootstrap and the build process fails. Would be nice to get some feedback on that as soon as possible. Because I will have to build my own starter instead, but thought it would be nice to build upon your great work. But the way it currently is it is not usable for our projects with outdated packages and vulnerabilities

jedrzejchalubek commented 3 years ago

@niklasp Yup, fully understanding! However, I cannot give you any estimates as I have mentioned in https://github.com/tonik/theme/issues/94 we do not focus on WP work lately

About, tonik/cli. It defines package names inside its scaffolding presets in here: https://github.com/tonik/cli/tree/develop/src/CLI/Scaffolding/Presets For example Bootstrap preset. It is only a matter of changing names inside tonik/cli repository 😄

niklasp commented 3 years ago

@jedrzejchalubek Yes I could totally do that, however if i would add a PR in tonik/cli, the different versions would not work together anymore unless we would add a version check?

jedrzejchalubek commented 3 years ago

@niklasp Not sure what do you mean by "different versions", but there is no need for checking versions of tonik/theme and tonik/cli programmatically. This will be handled by semantic versioning when publishing new releases.

I will take care of proper versions in composer.json file when publishing new releases of both repositories

niklasp commented 3 years ago

@jedrzejchalubek I managed to test with composer local cli repo on develop branch. Was successful (as far as I could tell) for all scaffolding (vue/bulma/bootstrap/foundation). Happy to hear back from you

we do not focus on WP work lately

we all need a WordPress theme at sometime, even if our company does not :)