search

tonik / theme

Tonik is a WordPress Starter Theme which aims to modernize, organize and enhance some aspects of WordPress theme development.
http://labs.tonik.pl/theme/
MIT License
1.33k stars 140 forks source link

replace deprecated node-sass with dart sass #104

Open wxw-matt opened 3 years ago

wxw-matt commented 3 years ago

As node-sass is deprecated and it does not work on arm64 (Apple M1), I fix this by using dart sass.

Ref34t commented 3 years ago

Hey @wxw-matt how did you replace node-sass by dart sass

mariusintlwerft commented 2 years ago

Does it work with node 18 if you just change that? Have you test it? Does it work for you? @wxw-matt

wxw-matt commented 2 years ago

Does it work with node 18 if you just change that? Have you test it? Does it work for you? @wxw-matt

Hi @virgin71 , I haven't tested it. It should work according to description:

Node.js Compatibility We consider dropping support for a given version of Node.js to be a breaking change as long as that version is still supported by Node.js. This means that releases listed as Current, Active LTS, or Maintenance LTS according to the Node.js release page. Once a Node.js version is out of LTS, Dart Sass considers itself free to break support if necessary.

https://github.com/sass/dart-sass

mariusintlwerft commented 2 years ago

Yeah, but adding that one only, will break other dependences.

wxw-matt commented 2 years ago

Yeah, but adding that one only, will break other dependences.

True, sometimes it happens. Have to fix it one by one.