tonikelope / megabasterd

Yet another unofficial (and ugly) cross-platform MEGA downloader/uploader/streaming suite.
GNU General Public License v3.0
4.61k stars 598 forks source link

8.8 Failing to load links #599

Closed beesyrupfactory closed 11 months ago

beesyrupfactory commented 11 months ago

I recently updated to v8.8 on macos sonoma using the JAR file. When copying in a link, it doesn't load and goes on forever. Downgraded to v8.4, and it works fine. I've also tried v8.7 also. So it may be possible that the logic between 8.4 -> 8.7 has changed and is preventing the links from loading.

nomadism19 commented 11 months ago

Same here. Copying URL and typing URL manually both change the contents of link.

tonikelope commented 11 months ago

Sample MEGA link?

8.7, 8.5 ?

DEBUG FILE? (Advanced settings)

beesyrupfactory commented 11 months ago

Thanks for your response Antonio @tonikelope

I will provide the link, debug logs shortly. I will test on 8.5. 8.7 link extractor doesn't work, same as 8.8.

beesyrupfactory commented 11 months ago

The behavior only seems to affect mega links that include a folder. For single files, there was no problem.

  1. Sample MEGA link that is not working: https://mega.nz/#F!gSokWLzQ!CfTNkr4pq5BbmzGLI9Y3fQ (windows 7 custom iso)
  2. Working Sample MEGA link: https://mega.nz/file/rkkEnChZ#f92ZU1rHiwdSBlcQWkugnsF0jO6f_EjhGdvF6YFna78
  3. Tested against 8.8
  4. DEBUG logs : MEGABASTERD_DEBUG.log

Edit: Bad formatting on my original comment. Sorry about that. Edit2: Additional finding

tonikelope commented 11 months ago

Please try 8.9

The problem is that you are probably using an old Java version like Java 8. I have modified a piece of code to keep it compatible, but I recommend that you upgrade to Java 11 as a minimum (or try portable version that includes Java 14).

beesyrupfactory commented 11 months ago

Hi @tonikelope,

Thanks for your quick response. Yeah, you're absolutely right. My Java version is 1.8:

$ java -version java version "1.8.0_391" Java(TM) SE Runtime Environment (build 1.8.0_391-b13)

It's still reproducible in 8.9 using the broken link above, but I will try updating my system JDK to 11 or 14 and get back to you shortly.

beesyrupfactory commented 11 months ago

Fixed while using OpenJDK 21.0.1 on macOS with Homebrew, and updating the PATH variable with the updated OpenJDK version.

$ java -version
openjdk version "21.0.1" 2023-10-17
OpenJDK Runtime Environment Homebrew (build 21.0.1)
OpenJDK 64-Bit Server VM Homebrew (build 21.0.1, mixed mode, sharing)

You are absolutely right. It seems that the methods that were implemented in the latest updates were incompatible with v8.7+.

Appreciate your support @tonikelope! This can be closed 👍

beesyrupfactory commented 11 months ago

Oh, one suggestion!

Perhaps in the readme.md it might be worth mentioning that Java 8 is no longer supported for those running MegaBasterd via JAR file.