tonini / alchemist-server

Editor/IDE independent background server to inform about Elixir mix projects
193 stars 12 forks source link

No response if DEFL can't find definition #17

Open redpublic opened 7 years ago

redpublic commented 7 years ago

When DEFL can't find definition, it doesn't return end-marker and no any info regarding response details, just error in server log

00:49:06.550 [error] Task #PID<0.149.0> started from #PID<0.147.0> terminating ** (MatchError) no match of right hand side value: ["Orders"] /Users/p_hrechyshkin/workspace/self/alchemist-server/lib/api/defl.exs:84: Alchemist.API.Defl.normalize/1 /Users/p_hrechyshkin/workspace/self/alchemist-server/lib/api/defl.exs:13: Alchemist.API.Defl.request/1 /Users/p_hrechyshkin/workspace/self/alchemist-server/lib/helpers/process_commands.exs:21: Alchemist.Helpers.ProcessCommands.process/2 /Users/p_hrechyshkin/workspace/self/alchemist-server/lib/server/socket.exs:47: Alchemist.Server.Socket.serve/2 (elixir) lib/task/supervised.ex:85: Task.Supervised.do_apply/2 (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3 Function: #Function<0.65933552/0 in Alchemist.Server.Socket.loop_acceptor/2> Args: []

There is also different error in log in case DEFL has incorrect syntax. Is it intended behavior? Any plans to add error responses for such cases?