search

tonini / alchemist.el

Elixir Tooling Integration Into Emacs
http://www.alchemist-elixir.org
906 stars 103 forks source link

Fixing docstring documentation not found #293

Closed herdigiorgi closed 7 years ago

herdigiorgi commented 7 years ago

This fixed the "No documentation for XXX found", when in fact the documentation exists in some rare cases.

There is a problem inside the function alchemist-utils-empty-string-p: The regex for checking an input of only spaces "^\s+$" is WRONG if there is just ONE line that is empty it matches:

ELISP> (string-match-p "^\s+$" " \nx\n x") 0 (#o0, #x0, ?\C-@) ; wrong ELISP> (string-match-p "^\s+$" "121sdfadf") nil The result in both cases should nil. I don't know how to regex multiple lines in emacs. So my solution is to simplily remove that string-match-p.

tonini commented 7 years ago

Hi @diaes256

Thanks for the PR. I had some time today and updated the Alchemist-Server and also added the issue with the empty-string function. It's already on the master.

Thanks for your patiences.