search

tonini / alchemist.el

Elixir Tooling Integration Into Emacs
http://www.alchemist-elixir.org
906 stars 103 forks source link

Prevent *Alchemist-IEx* buffer from hanging while waiting for input #314

Closed whysoserious closed 6 years ago

whysoserious commented 7 years ago

Alchemist-IEx buffer was hanging eg. when received a IO.gets(:stdio) command and had to be killed by C-q command. Removing lines 198-199 seems to solve this problem. This commit also removes alchemist-iex-seen-prompt and whole logic associated with it which seems to be obsolete from now.

whysoserious commented 7 years ago

Solves #313 and #297 for me.

I am not aware of any negative consequences of merging this PR but also I am not familiar with codebase of this project.

damon-kwok commented 7 years ago

cool~

OvermindDL1 commented 6 years ago

What is wrong with this PR that needs to be fixed before it is merged @tonini ?

deepakjacob commented 6 years ago

@tonini - this fix works for me. can you please take a look at it ?

vaartis commented 6 years ago

Why isn't this merged yet..? It basically prevents (at least me) from using the repl in alchemist..

maruks commented 6 years ago

This happens because sometimes IEX sends color control codes before prompt. Alchemist can't find prompt and goes into infinite loop. I use my fork of alchemist. https://github.com/maruks/alchemist.el I don't know why they refuse to fix their code LOL

michalmuskala commented 6 years ago

It's all run by volunteers who sometimes have other things to do. Please refrain from comments like this.

whysoserious commented 6 years ago

Thanks for merging @tonini <3