tonini / alchemist.el

Elixir Tooling Integration Into Emacs
http://www.alchemist-elixir.org
906 stars 103 forks source link

Switch default keybinding from C-c a to C-c ; #324

Open Trevoke opened 6 years ago

Trevoke commented 6 years ago

This is a simple, mostly configuration-based PR that addresses #229 and brings alchemist into the rank of the packages that respect emacs conventions.

There's probably more things I need to do here, like regenerate the PDF and such, but I'm not sure how to do it.

I also know that just merging in this PR is no easy feat, but if we don't open it, we'll NEVER merge it :)

tonini commented 6 years ago

@Trevoke Thanks a lot mate. :green_heart:

This is something we started to discuss a while back ago but my daily life got me quite busy in the last time. So I'm glad you made the first step. :+1:

I'll have a look on in today and also try to add the missing parts where we have to change as well.

Thanks.

Trevoke commented 6 years ago

I can also do more of the work if you want, just point me in the right direction :)

tonini commented 6 years ago

@Trevoke I guess when we merge this one we should soon release another version. But I think it would be a good step in the right direction to refine these keybindings.

Currently I think the Alchemist-Server needs to be redone with https://github.com/msaraiva/elixir_sense

@Trevoke do you think you could have a look at https://github.com/msaraiva/elixir_sense ? :)

Trevoke commented 6 years ago

Of course! I'll take a look at it this week.

On Mon, Oct 30, 2017 at 2:15 AM Samuel Tonini notifications@github.com wrote:

@Trevoke https://github.com/trevoke I guess when we merge this one we should soon release another version. But I think it would be a good step in the right direction to refine these keybindings.

Currently I think the Alchemist-Server needs to be redone with https://github.com/msaraiva/elixir_sense

@Trevoke https://github.com/trevoke do you think you could have a look at https://github.com/msaraiva/elixir_sense ? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tonini/alchemist.el/pull/324#issuecomment-340352847, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEJSTsrC2hH1u9YA5Dxqak2obirAIyYks5sxWlugaJpZM4PdMBQ .

dsdshcym commented 6 years ago

Currently I think the Alchemist-Server needs to be redone with https://github.com/msaraiva/elixir_sense

Any updates on this?

mdbergmann commented 5 years ago

Please merge this PR. "C-c a" causes some trouble: #354 However, there might still be a problem with configuring the default keybinding.

kentbull commented 4 years ago

@mdbergmann and @Trevoke this issue seems like a good candidate for testing our deployment workflow for resurrecting this project. It's simple and easy to grok. Have either of you had any thoughts on this issue in the intervening months since its inception?

kentbull commented 4 years ago

@dsdshcym yes, the project is forked and moved here: https://github.com/elixir-lsp/elixir_sense