Closed jekku closed 5 years ago
Hi @jekku That's looks like an easy add, although there are missing tests I would like to have for the usage of the this specific Elixir feature. There are already a few tests available which creating buffer for testing these kind of functionality. Maybe you have a look at them.
@Trevoke format
is a Elixir 1.6 feature right? what do you think about handling different versions of Elixir in Alchemist so far? Actually, I would like to just go ahead and try to be as up to date as possible and not try to be valid for Elixir versions way beyond v1.6.
Yeah, format
is Elixir 1.6. I think we'll eventually want to handle
different versions in the future, but I don't think we have to worry about
that just yet.
I know that go-mode provides a gofmt
command that calls go-fmt
, so it's
probably fine to have the mix format
tool be in elixir-mode.. But if so,
should it also be in alchemist?
On Mon, Feb 19, 2018 at 2:04 AM Samuel Tonini notifications@github.com wrote:
@Trevoke https://github.com/trevoke format is a Elixir 1.6 feature right? what do you think about handling different versions of Elixir in Alchemist so far? Actually, I would like to just go ahead and try to be as up to date as possible and not try to be valid for Elixir versions way beyond v1.6.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tonini/alchemist.el/pull/339#issuecomment-366604300, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEJSWxfdLuWRcWtsDeAca3wlKBF3kLKks5tWRz7gaJpZM4SDZhZ .
Folks @jekku There is a PR open already in emacs-elixir https://github.com/elixir-editors/emacs-elixir/pull/406
Could you help there?
@jekku Think you could add some testing around this functionality to your PR?
@Trevoke gonna read on the how-to-test
I know that go-mode provides a
gofmt
command that callsgo-fmt
, so it's probably fine to have themix format
tool be in elixir-mode.. But if so, should it also be in alchemist?
That's actually a good point, I also think elixir-mode
could be the better place for it. mix format
is already runnable from inside Alchemist through alchemist-mix
.
This connects alchemist mix tasks with mix format.
Mix Format was made available in Elixir 1.6 which helps people stick with single conventions. Having these with emacs alchemist would be a great help to emacs users working with Elixir. May be the way to solve #337