search

tonini / alchemist.el

Elixir Tooling Integration Into Emacs
http://www.alchemist-elixir.org
906 stars 103 forks source link

Fix Phoenix project detection #352

Closed J3RN closed 1 year ago

J3RN commented 5 years ago

Spiritual successor to #321

From the original:

The `web' directory is removed with phx1.3 and placed under lib/<app-name>_web instead. Also change phoenix.routes -> phx.routes

My changes:

I changed the name of the alchemist-app-name to alchemist-phoenix--app-name to indicate that it's 1) part of the alchemist-phoenix functionality and 2) a "private" function

For the sake of testing (and I was having great trouble with that), I generated a dummy Phoenix project. This project is admittedly larger than the dummy_elixir fixture, and I'm open to alternate approaches to this. Both projects together are still smaller than the images :smile:

benbot commented 5 years ago

This is great. I was just about to open a PR with the same fix.

Great work!

baron commented 5 years ago

would love to see this merged