tonini / alchemist.el

Elixir Tooling Integration Into Emacs
http://www.alchemist-elixir.org
906 stars 102 forks source link

Cannot go back using alchemist-goto-jump-back(M-,). #376

Open wettoast4 opened 2 months ago

wettoast4 commented 2 months ago

Phenomenon: After jumping to a different location using 'M-.' (alchemist-goto-definition-at-point), I expected that 'M-,' would restore the original location, but the minibuffer displayed 'At start of xref history'.

Suggested solution: This seems to be related to that 'find-tag-marker-ring' function is obsolete (Obsolete in Emacs 25.1, released in Sep 2016 ). I think the following fix to the lines 140 and 222 in bodies of 'alchemist-goto-list-symbol-definitions' and 'alchemist-goto--open-definition' functions in alchemist-goto.el will get it work. But I'm not confident if this modification does not affect other parts because I have less experience on ELISP language. Please point out if I'm wrong.

before fix: (ring-insert find-tag-marker-ring (point-marker)) after fix: (xref-push-marker-stack (point-marker))

versions I used: