search

tonioluna / fake_sky_chart_generator

Random sky chart generator. Generated charts are made so each chart can be repeated multiple times, vertically and horizontally, with a perfect match.
GNU General Public License v3.0
2 stars 0 forks source link

Can this work with real data? #1

Open vzhilov opened 2 years ago

vzhilov commented 2 years ago

Thank you for sharing you code, it happen this is exactly what I need! But I’m trying to make it work with the real space research data, like astropy, showing a target star with some of its neighbors . Would you be available to make such a feature?

tonioluna commented 2 years ago

I don't think that would be easy to do. The code I have does not know anything about a real coordinate system. However, I have used this one in the past to generate charts out of actual data: https://github.com/codebox/star-charts

vzhilov commented 2 years ago

Thank you for your fast response.

It seems like if we change get_random_stars function, partially the lines:

   w = random.random()*max_w
   h = random.random()*max_h

to the real coordinates gotten by astropy:

from astropy.coordinates import SkyCoord 
from astropy import units as u
c = SkyCoord(ra=ra1*u.degree, dec=dec1*u.degree)  
catalog = SkyCoord(ra=ra2*u.degree, dec=dec2*u.degree)
idxc, idxcatalog, d2d, d3d = catalog.search_around_sky(c, 1*u.deg)

we could get the real sky chart with some stars around.

Am I thinking in the right way?

The other script of codebox you have mentioned looks good but I couldn't find if it is possible to change the graphics to display it in a style like yours.

tonioluna commented 2 years ago

I'm not familiar with Astropy. Does it provide standard x, y coords? Is some projection requiered?

I sounds like an interesting idea. I suppose github supports branches on public projects. Feel free to branch, play around, and once it's working it can be merged back to master.

On Thu, Jan 20, 2022, 12:45 vzhilov @.***> wrote:

Thank you for your fast response.

It seems like if we change get_random_stars function, partially the lines:

w = random.random()max_w h = random.random()max_h

to the real coordinates gotten by astropy:

from astropy.coordinates import SkyCoord from astropy import units as u c = SkyCoord(ra=ra1u.degree, dec=dec1u.degree) catalog = SkyCoord(ra=ra2u.degree, dec=dec2u.degree) idxc, idxcatalog, d2d, d3d = catalog.search_around_sky(c, 1*u.deg)

we could get the real sky chart with some stars around.

Am I thinking in the right way?

The other script of codebox you have mentioned looks good but I couldn't find if it is possible to change the graphics to display it in a style like yours.

— Reply to this email directly, view it on GitHub https://github.com/tonioluna/fake_sky_chart_generator/issues/1#issuecomment-1017810864, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD6FIMFAQO4CBI7GWQSW3VDUXBJ3ZANCNFSM5MMGF2NQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>