search

tonioni / WinUAE

WinUAE Amiga emulator
http://www.winuae.net/
528 stars 86 forks source link

bugfix: fixed inversed x/y gfx coordinates #231

Closed midwan closed 1 year ago

midwan commented 1 year ago

It appears that the x/y coordinates saved for the top/left window position were inversed in the config file.

This fixes them so that x=left and y=top, as I believe it was meant to be.

tonioni commented 1 year ago

I don't think I want to fix this because then it would be very annoying if window position changes when using older version vs newest version.

midwan commented 1 year ago

True, but that would only happen once - if the config is saved again, it would get the correct values updated. It's up to you of course, but in my mind it's better to fix it going forward, instead of leaving a bug there forever, due to some minor inconvenience? I don't think the window position being wrong due to this (until you re-save the config) is such a big issue for users.

tonioni commented 1 year ago

Yeah but if it gets saved with fixed order, using any old version would be annoying which is not rare enough case. Backwards compatibility is important for me.

Only way to fix this without side-effects would be to create new entries that only new versions use. Old entries are only used if new entries are not found (or if old version is used). I'll probably do it this way. Getting defaults is much better choice than getting inverted options.