tonioni / WinUAE

WinUAE Amiga emulator
http://www.winuae.net/
545 stars 87 forks source link

debugmem.cpp@branch_stack_push can overflow #240

Closed BartmanAbyss closed 1 year ago

BartmanAbyss commented 1 year ago

stackframecnt and stackframecntsuper are not checked against MAX_STACKFRAMES. Had a case where it overflowed, corrupted the heap and crashed WinUAE.

tonioni commented 1 year ago

Whats the best option? Do nothing (+log warning message?) if limit reached?

BartmanAbyss commented 1 year ago

Hmm.. dunno. maybe warn once + disable stackframes altogether. at this point there's probably some infinite loop going on anyway.

tonioni commented 1 year ago

Fixed in 4.10