search

tonioni / WinUAE

WinUAE Amiga emulator
http://www.winuae.net/
545 stars 87 forks source link

added missing #ifdef statements #245

Closed midwan closed 1 year ago

midwan commented 1 year ago

Mostly those requiring DEBUGGER, but also a few more

tonioni commented 1 year ago

Looks good but I don't like ifdefs that duplicate almost identical code lines (mainly floppybridge changes) because almost certainly I will miss the other one they will be out of sync sooner than later. I am not sure whats the best option but at least this isn't good way.

tonioni commented 1 year ago

Looks ok but why did aros rom change?

midwan commented 1 year ago

@tonioni It didn't - you had it ignored from gitignore, so I removed that from there and therefore the file is now showing as part of the repository. I think there's no reason to exclude it, as it's needed for building anyway :)

tonioni commented 1 year ago

Ah, right :)

But it is really long, ugly and pointless file (for any other purpose than compilation). Thats why I'd like to keep it out. (filesys_bootrom is technically same but it is at least short and sources are also included)

midwan commented 1 year ago

@tonioni Yeah, I know - but if you need it to compile the thing, better have it in the repository regardless.

In Amiberry, I've completely removed it and I'm using external Aros ROM files, instead. That way, I can upgrade them if newer versions come along easily. Not sure if you also prefer that approach, as it means that new releases will need to have those binaries packaged with them, instead of having it embedded in the executable.