tonioni / WinUAE

WinUAE Amiga emulator
http://www.winuae.net/
528 stars 86 forks source link

Multiple IDE boards - disk on second board also appears on first #259

Closed LIV2 closed 8 months ago

LIV2 commented 8 months ago

Hi Toni,

I've been working on adding my CIDER IDE interface to WinUAE here

However I've noticed that if I add a disk as unit 0 on the second board, it appears as unit 2 on the first one as well for some reason.

I'm not sure if this is something I've missed or a bug

image

tonioni commented 8 months ago

How did you configure it? It should say "CIDER IDE:0" and "CIDER IDE:2" in GUI. Not "CIDER IDE:0/2" (Did you add two CIDER boards? Not that it still would not explain what happens, unless the driver gets confused by having two identical boards)

btw, code looks fine but please put autoconfig data in expansion.cpp (like Buddha), it is newer and better way.

LIV2 commented 8 months ago

How did you configure it? It should say "CIDER IDE:0" and "CIDER IDE:2" in GUI.

Two CIDER boards, with blank.hdf as unit 0 for the second board

unless the driver gets confused by having two identical boards)

It shouldn't be - each instance of the driver only attaches to one board so in this instance we have lide.device for the first board and 2nd.lide.device for the second board

btw, code looks fine but please put autoconfig data in expansion.cpp (like Buddha), it is newer and better way.

Ok will do 👍

tonioni commented 8 months ago

Should be fixed now. Controller with more than 1 IDE channel + same controller configured more than once caused wrong IDE table indexing.

LIV2 commented 8 months ago

Thanks! 😀