search

tonioni / WinUAE

WinUAE Amiga emulator
http://www.winuae.net/
543 stars 87 forks source link

"Power led dims when audio filtered is disabled" bug #266

Open johnnovak opened 9 months ago

johnnovak commented 9 months ago

When this option is enabled, it inserts power_led_dim=128 into the config. That indeed causes the power LED to dim if the soft-switchable filter is enabled in the native on-screen display (verified it in Protracker with the E00 and E01 commands). But it also hard-enables the filter on the audio output so it's impossible to turn it off -- this is a bug.

So, the LED toggles alright, but the filter in the audio path is always enabled when this option is on.

Confirmed the behaviour with a brand new clean config created with the Quickstart in 5.1.0 and also in 4.9.1, so it appears this is not a new regression.

tonioni commented 9 months ago

Confirmed and fixed. As a workaround, power_led_dim value less than 96 will not affect filter state.

johnnovak commented 9 months ago

Thanks Toni.

johnnovak commented 8 months ago

@tonioni Tested with 5.2.0 RC2, and now the audio is correct regardless of the "Power led dims when audio filtered is disabled" setting. That's good.

But changing the setting at runtime doesn't work, the change is not reflected in the native OSD. You need to save the config and reload it so the state of the option is reflected on the OSD.

Minor thing, but technically it's still buggy, so I thought it's worth mentioning.