tonioo / sievelib

Client-side Sieve and Managesieve library written in Python.
MIT License
46 stars 24 forks source link

Problems with pip >=10 and pip.req #72

Closed fernand0 closed 6 years ago

fernand0 commented 6 years ago

Hello,

it seems that pip 10 does not allow the use of pip.req (https://stackoverflow.com/questions/25192794/no-module-named-pip-req). I've tested with this workaround and it seems to work well.

codecov[bot] commented 6 years ago

Codecov Report

Merging #72 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files          10       10           
  Lines        1683     1683           
=======================================
  Hits         1415     1415           
  Misses        268      268

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d28ce4...4f06b07. Read the comment docs.

tonioo commented 6 years ago

Thank you.

leenaars commented 6 years ago

@tonioo : I had this same issue, and the patch fixed this for me. Would you be so kind to tag a new release, including this patch? Thanks for the great library, BTW!