search

tonioo / sievelib

Client-side Sieve and Managesieve library written in Python.
MIT License
46 stars 25 forks source link

Python 3.8 readiness #88

Closed icgood closed 4 years ago

icgood commented 4 years ago

87 addressed this warning:

.venv/lib/python3.7/site-packages/sievelib/commands.py:26
  /home/ian/dev/pymap/.venv/lib/python3.7/site-packages/sievelib/commands.py:26: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    from collections import Iterable

However, the latest tagged version 1.1.1 is a bit behind at this point and does not include the fix. With Python 3.8 hitting its first release candidate and a possible final release in less than a week, I am hoping for a tagged version that's 3.8 ready. Thanks!

icgood commented 4 years ago

Update: tested in Python 3.8 and the warning has changed to:

.venv/lib/python3.8/site-packages/sievelib/commands.py:26
  /home/ian/dev/pymap/.venv/lib/python3.8/site-packages/sievelib/commands.py:26: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    from collections import Iterable

So it appears they have deferred the full deprecation until 3.9.