generateUrl opens browser automatically

toniov / gcal-cli

Google Calendar command line tool for Node.js

273 stars 31 forks source link

generateUrl opens browser automatically #5

Open mcamara opened 7 years ago

mcamara commented 7 years ago

For lazy people (as me), copying and pasting the url is too much hassle. With this small fix, the url is automatically open in user's default browser.

Thanks for the good work!

toniov commented 7 years ago

Thanks for the PR!

A couple of things:

Maybe it's not a good idea to open the browser without asking first (plus it would be a breaking change). Doing it through an option could be a better idea (something like $ gcal generateUrl -o.
It needs to be cross-platform, using opn it could be implemented easily.

mcamara commented 7 years ago

You're right, I always forget windows users! I'll fix it later!

mcamara commented 7 years ago

I've made the changes we talked about. What do you think now? 😸

toniov commented 7 years ago

Thanks! Looks good!

Besides the comments, if you add the new option to help.js we are good to go I think!