tonistiigi / mega

THIS REPO IS NOT MAINTAINED. Unofficial Node.js SDK for Mega
http://tonistiigi.github.com/mega
118 stars 33 forks source link

Added support to be able to get file id by name #18

Closed manvir-singh closed 10 years ago

manvir-singh commented 10 years ago

Get file id knowing only the files full name. Returns the name of the file.

manvir-singh commented 10 years ago

This is my first ever pull request sorry if i made any mistakes.

tonistiigi commented 10 years ago

Sorry, this does not add much value in my opinion. Its a very specific problem that you are solving. There is a general one-liner for getting any active file object(any property) for any condition. That is much better in my opinion.

Also there are several code issues. For example function name, misleading comment, prototype where its defined and performance considerations.

manvir-singh commented 10 years ago

Ok that's fine