search

tonkeeper / wallet

GNU General Public License v3.0
327 stars 82 forks source link

iOS: It is possible to create send transactions for the future #29

Closed julialips closed 2 years ago

julialips commented 2 years ago

Bug Type

Functional

Reproduction steps

  1. Open Tonkeeper app
  2. Log in to your wallet or create new one
  3. Go to device settings (Settings - General - Data & Time)
  4. Switch off 'Set Automatically' switcher
  5. Set manually the date: 2 day forward
  6. Open the app
  7. Make send transaction Actual result: Pending transaction is created and displayed on the UI. But the funds were successfully sent.
  8. Return device settings, switch on 'Set Automatically' switcher
  9. Return to the app

Actual result

There is pending transactions for the future date.

image_2022-09-18_23-37-50

Expected result

Some ways:

  1. You have good check for 'Set automatically' feature. This check may be for every send transactions, which will not allow to proceed this case, if the setting is off.
  2. As transactions really were send, I guess, it is only UI bug. You may clear pending transactions from the future pending list, if these transactions were send, may be some check by transaction id may help.

Suggested Severity

High

Device

Device: iPhone 11 OS: 14.3

Additional Context

No response

MariaBit commented 2 years ago

Hi, the issue has been already fixed and will be available in the next release.

For the specified case, the incorrect behavior for pending transaction has been fixed. And we also added a warning message to inform users that they need to turn on automatic time and date on their device if it is turned off.

Thanks!