Mobile View Portfolio Website

[tonnymuchui]

Created mobile view portfolio using HTML and CSS. I also used linters to check my code and CSS

[tonnymuchui]

working on Portfolio mobile view website page. Made use of HTML&CSS and linters.

[tonnymuchui]

Thank you so much for the project review and feedback. I will work on the professional coding practices you highlighted. kind regards

On Fri, Aug 19, 2022 at 10:24 PM Toma John Musa @.***> wrote:

@.**** approved this pull request.

Hi @tonnymuchui https://github.com/tonnymuchui,

Your project is complete! There is nothing else to say other than... it's time to merge it [image: :shipit:] Congratulations! 🎉 Highlights

• ALl linters passed
• Correct use of Github flow

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

In index.html https://github.com/tonnymuchui/Portfolio/pull/1#discussion_r950498909:

+

• <link @.***&display=swap" rel="stylesheet">

+

+

• My Logo

• • ☰

• I'm Tonny Glad to see you

  -

  [Optional] Please note that it is best practice and a convention to use indentation of 2 spaces in all your documents. You can check here https://github.com/microverseinc/curriculum-html-css/blob/main/articles/html_css_best_practices.md for more details.

  [Optional] It's better to follow commit message standards by making them capitalized and in the imperative form (Example: 'Modify readme file' instead of 'modified readme'). This way, your commit history will be more readable and more professional ✨

---

In css/styles.css https://github.com/tonnymuchui/Portfolio/pull/1#discussion_r950501344:

• font-family: 'Poppins', sans-serif !important;

• font-style: normal;

• font-weight: 700;

• font-size: 40px;

• display: flex;

• align-items: center;

• color: #172b4d;

• flex: none;

• order: 0;

• flex-grow: 0;

+}

+

+.content-text {

• width: 300px;

• height: 100px;

• font-family: 'Poppins', sans-serif !important;

• font-style: normal;

  -

  [Optional] Please note that it is best practice not to repeat multiple !important properties in your CSS. Check here https://github.com/microverseinc/curriculum-html-css/blob/main/articles/html_css_best_practices.md for more details.

  [Optional] Consider creating a class for the font family and assigning the class to the HTML elements that requires it rather than repeatedly using the class. This is best practice for DRY https://en.wikipedia.org/wiki/Don%27t_repeat_yourself code.

— Reply to this email directly, view it on GitHub https://github.com/tonnymuchui/Portfolio/pull/1#pullrequestreview-1079269416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVSLTNG5G6DPFYGPPAA46TVZ7NOHANCNFSM566BSTOQ . You are receiving this because you were mentioned.Message ID: @.***>