search

tonnymuchui / Portfolio-1

This my Personal Portfolio
MIT License
1 stars 0 forks source link

Accessibility of my website page. #10

Closed tonnymuchui closed 2 years ago

tonnymuchui commented 2 years ago
tonnymuchui commented 2 years ago

Hello. I would like to know what exaclty changes I'm required to make. Thank you.

On Tue, Aug 30, 2022 at 2:18 PM mwanawabangona @.***> wrote:

@.**** requested changes on this pull request.

Hi @tonnymuchui https://github.com/tonnymuchui,

Good job so far!

https://camo.githubusercontent.com/38ce8c8b213b08e2d9bb85a0b79702ad512f3910f803ec3d7917b4e0110c9044/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f7741366159414f336a4836526d55494259732f67697068792e676966 There are some issues that you still need to work on to go to the next project but you are almost there! Highlights

  • ✅ No linter errors ✔️
  • ✅ Repo looks professional 💼
  • ✅ Good quality commits

Required Changes ♻️

Check the comments under the review. Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

In index.html https://github.com/tonnymuchui/Portfolio/pull/10#discussion_r958338190:

         <div class="work-card">
  • SnapshootPortfolio02-img 
           <div class="align-center-text">

         <h3 class="work-heading">Tonic</h3>

         <ul class="dev-date">
    • required
    • amazing working so far
    • however, the contrast is failing on this section on all the cards.

[image: 1constrast] https://user-images.githubusercontent.com/66230306/187420569-5a5328f1-914e-413e-9066-b91d82778161.png

please make amends

— Reply to this email directly, view it on GitHub https://github.com/tonnymuchui/Portfolio/pull/10#pullrequestreview-1090112170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVSLTPYXHT7JTQD6RF3WVTV3XUY7ANCNFSM6AAAAAAQAFMJ6I . You are receiving this because you were mentioned.Message ID: @.***>

tonnymuchui commented 2 years ago

kindly could you mind if we have a 5min zoom meeting, please?

On Tue, Aug 30, 2022 at 2:36 PM mwanawabangona @.***> wrote:

@.**** commented on this pull request.

In index.html https://github.com/tonnymuchui/Portfolio/pull/10#discussion_r958365317:

         <div class="work-card">
  • SnapshootPortfolio02-img 
           <div class="align-center-text">

         <h3 class="work-heading">Tonic</h3>

         <ul class="dev-date">

@tonnymuchui https://github.com/tonnymuchui please see the above comment.....if needed we can do a zoom call. 🥂

— Reply to this email directly, view it on GitHub https://github.com/tonnymuchui/Portfolio/pull/10#discussion_r958365317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVSLTO374SVDLBPGXSCVODV3XW3JANCNFSM6AAAAAAQAFMJ6I . You are receiving this because you were mentioned.Message ID: @.***>

tonnymuchui commented 2 years ago

Thanks for the feedback!

On Wed, 31 Aug 2022, 11:39 Sumair Qaisar @.***> wrote:

@.**** approved this pull request. Hi Team ,

https://camo.githubusercontent.com/d8de195a08af080c4ae2fd36bfcf741de68f66af2162d291a21e113ce1b490fc/68747470733a2f2f6d65646961342e67697068792e636f6d2f6d656469612f42504a6d74685133595277443651716356442f67697068792e676966

Your project is complete! There is nothing else to say other than... it's time to merge it [image: :shipit:] Congratulations! 🎉 Highlights

✔️ Good commit history ✔️Linters are passing ✔️Very professional README ✔️Correct Github flow ✔️Descriptive PR Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

— Reply to this email directly, view it on GitHub https://github.com/tonnymuchui/Portfolio/pull/10#pullrequestreview-1091506937, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVSLTLOUVICAZK5ZHGHWWTV34K25ANCNFSM6AAAAAAQAFMJ6I . You are receiving this because you were mentioned.Message ID: @.***>