Works popup window - Githubissues

tonnymuchui / Portfolio-1

This my Personal Portfolio

MIT License

1 stars 0 forks source link

I was requesting if it could be possible we spend like 10min on zoom you help me to know how I will implement project card on the right

On Thu, Sep 8, 2022 at 11:18 AM Shoira @.***> wrote:

@.**** commented on this pull request.

Hi team,

👍 This is good to make it this far, your project is really nice, congratulations on the good work you have done so far.

First let me to point out:

Modal window works as expected ✔️

You passed all the Linters! ✔️

Data is retrieved dynamically ✔️

Keep on coding, good job so far! 👏

There are some issues that you still need to work on to go to the next project but you are almost there!

https://camo.githubusercontent.com/7a3175b24229512cc970aece8b2e2de8a06ce098a4f0ba2c4079f9a4f9152c29/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f644550476b6e5269456e6965632f67697068792e676966 Required Changes ♻️

Please check the readme file, some sections look broken:

[image: Screenshot 2022-09-08 at 11 17 41] https://user-images.githubusercontent.com/77038610/189072005-61a344c8-c7bb-443e-9b38-c038bab7d626.png

Check the comments under the review.

Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear by mentioning my Github username.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

In index.html https://github.com/tonnymuchui/Portfolio/pull/12#discussion_r965642734:

onclick="window.location.href = 'https://github.com/tonnymuchui/Portfolio';"

See Project

As you can see, project's text content should be on the left or on the right depending on the flow. But in your case, it is always on the right

'A daily selection of privately personalized reads; no accounts or sign-ups required.',

languages: ['html', 'css', 'javascript'],

+];

+const worksCard = cards.map(

(card, index) => `

tonnymuchui / Portfolio-1

Works popup window #12

Check the comments under the review.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Multi-Post Stories

Facebook 360

Uber Navigation

As you can see, project's text content should be on the left or on the right depending on the flow. But in your case, it is always on the right

${card.title}