search

tonnymuchui / Portfolio-1

This my Personal Portfolio
MIT License
1 stars 0 forks source link

Work section& about section #2

Closed tonnymuchui closed 2 years ago

tonnymuchui commented 2 years ago

created a work&about section in my portfolio project to show some of my work and about me.

tonnymuchui commented 2 years ago

Hello. Have done all the changes and requested extra review. I hope now it looks good. Thank you

On Sat, Aug 20, 2022 at 8:12 PM Francisco Borja Lobato < @.***> wrote:

@.**** requested changes on this pull request.

Hi @tonnymuchui https://github.com/tonnymuchui ,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet. Highlights

  • No liner errors ✔️
  • Correct Github flow 💯

Required Changes ♻️

Check the comments under the review.

  • Please, add a descriptibe title on your Pull Request.
  • Kindly we could delete the sections on README file tahht we are not using yet.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

In index.html https://github.com/tonnymuchui/Portfolio/pull/2#discussion_r950717056:

  • or sign-ups required.

    • html
    • css
    • javascript

  • Molt-post Stories

    • [image: image] https://user-images.githubusercontent.com/58642949/185758190-633f639b-2b80-4c6c-a0b6-e120fd2d20bd.png

    [image: image] https://user-images.githubusercontent.com/58642949/185758196-44d20736-a6a1-4519-a9a7-3579fe6785b0.png

    In css/styles.css https://github.com/tonnymuchui/Portfolio/pull/2#discussion_r950717198:

    +.container {

    +}

    https://user-images.githubusercontent.com/58642949/185758257-e375fb6e-54c6-412d-98e7-0021cce2a509.mp4

    In index.html https://github.com/tonnymuchui/Portfolio/pull/2#discussion_r950717586:

    -

    [OPTIONAL] Please, 🙏🏽 complete the icons to have a design similar to the Figma template. We could complete the icons on the homepage also.

    Figma template

    [image: image] https://user-images.githubusercontent.com/58642949/185758392-1a6cf196-b631-42a6-ad39-02e62f1e4d37.png

    [image: image] https://user-images.githubusercontent.com/58642949/185758407-86c1381f-c689-4a11-9626-3904f060272f.png

    — Reply to this email directly, view it on GitHub https://github.com/tonnymuchui/Portfolio/pull/2#pullrequestreview-1079556283, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVSLTPQQ3IRQI4NNE2EXGLV2EGX5ANCNFSM57DGZXPA . You are receiving this because you were mentioned.Message ID: @.***>

    tonnymuchui commented 2 years ago

    created a work&about section in my portfolio project to show some of my work and about me.