My contact

[tonnymuchui]

worked on the footer section html&css. where I added contact information and fixed linters error spaces

[tonnymuchui]

worked on the footer section html&css. where I added contact information

[tonnymuchui]

Working on them right now. Thank you.

On Wed, 24 Aug 2022, 19:23 Tresor Sawasawa @.***> wrote:

@.**** requested changes on this pull request. STATUS: REQUIRED CHANGES ♻️♻️

Hi @tonnymuchui https://github.com/tonnymuchui Good job so far! I know you worked hard to implement this project, I really appreciate the effort you put in! But there are some issues that you still need to work on to go to the next project but you are almost there!

[image: almost-there] https://user-images.githubusercontent.com/57562869/143511358-9cde7daf-4ad0-4db2-8f15-18b54288ff91.gif To highlight 🍾

• All linters are passing ✔️
• Good commit history ✔️
• Good PR description ✔️
• Follow GitHub flow ✔️

Required changes ♻️ ♻️

• Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please ping me @tresorsawasawa https://github.com/tresorsawasawa when you comment so I can receive the notification or use slack with the same name.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

In index.html https://github.com/tonnymuchui/Portfolio/pull/5#discussion_r953992952:

• <input

• class="name"

• name="name"

• type="text"

• placeholder="Enter your Name"

• id="name"

• maxlength="30"

• required="required"

• />

• <input

• class="email"

• name="email"

• type="email"

• placeholder="Enter your Email"

• id="mail"

• required="required"

• />

• <textarea

• class="message"

• id="msg"

• name="text"

• placeholder="Write your text in here"

• rows="8"

• cols="30"

• maxlength="500"

• required="required"

• Get It Touch
• Kindly make sure all the inputs elements and the Get In Touch button follow the design like your chosen Figma template(e.g.: alignment of inputs, buttons, and textarea; padding(top, bottom, left & right) used in inputs & textarea fields, the width of inputs & textarea fields, used font-family and padding in the textarea filed, alignment of the Get In Touch button,...). Make sure you check all the details from the Figma template and apply them to your project

Figma design Your Design [image: Screenshot from 2022-08-24 18-00-43] https://user-images.githubusercontent.com/83042742/186466681-3bc4b096-3b47-454c-a2b8-9c2050c31500.png [image: Screenshot from 2022-08-24 17-49-30] https://user-images.githubusercontent.com/83042742/186466775-b6f145f5-35cc-4fe5-9efc-60da8d163ea6.png

In index.html https://github.com/tonnymuchui/Portfolio/pull/5#discussion_r954012004:

[tonnymuchui]

added a horizontal line to the footer & fixed submit button