search

tonobo / hcloud-ruby

Native ruby client for HetznerCloud
MIT License
32 stars 11 forks source link

CI: Run on PRs and pushes to master #83

Closed bastelfreak closed 8 months ago

bastelfreak commented 1 year ago

This ensures that the CI runs on PRs from external contributors as well. Previously it on run when the PR was raised from a branch in the main repo.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a13bbfe) 98.44% compared to head (736b956) 98.44%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #83 +/- ## ======================================= Coverage 98.44% 98.44% ======================================= Files 121 121 Lines 4385 4385 ======================================= Hits 4317 4317 Misses 68 68 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skoch-hc commented 8 months ago

Looks reasonable to me. It seems Github also solved the issue of cryptomining PRs (3 years ago already). It's required to approve the pipeline for first time contributors.