Open tomByrer opened 8 years ago
I'd say if anything, raise the slash a little more so it's more obvious it's too characters combined. But honestly, I don't really see a problem with it.
Pertinent to add that I'm pretty sure the ending slash isn't even required in HTML5.
I'm pretty sure the ending slash isn't even required in HTML5.
True, but some auto-complete & rendering engines do add it, so I want to catch those. Plus it is still standard in XML, thus SVG which I use often.
@tomByrer do you even like something about this font at all? Looks like you’re just asking to turn everything off. What will remain?
I'm not sure where you got that idea? Sorry if I made you feel bad.
@tonsky
About this ligature, how about a scalene triangle? Like the one for |>
but angled?
It would be either too small (it has to take two horizontal places), or triangle would be too big and out of proportions with opening bracket
On Wed, Apr 13, 2016 at 4:15 AM easyaspi314 (Devin) < notifications@github.com> wrote:
@tonsky https://github.com/tonsky About this ligature, how about a scalene triangle? Like the one for |> but angled?
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/tonsky/FiraCode/issues/115#issuecomment-209125854
Well what about just aligning the slash to the caret? Instead of that weird overlap ? On Apr 13, 2016 5:30 AM, "Nikita Prokopov" notifications@github.com wrote:
It would be either too small (it has to take two horizontal places), or triangle would be too big and out of proportions with opening bracket
On Wed, Apr 13, 2016 at 4:15 AM easyaspi314 (Devin) < notifications@github.com> wrote:
@tonsky https://github.com/tonsky About this ligature, how about a scalene triangle? Like the one for |> but angled?
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/tonsky/FiraCode/issues/115#issuecomment-209125854
— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/tonsky/FiraCode/issues/115#issuecomment-209334376
How do you mean? A screenshot maybe?
This is roughly what I mean. I made a slightly better copy.
I got the idea, thanks. I think I like it the way it is now, sorry :)
On Wed, Apr 13, 2016 at 4:55 PM easyaspi314 (Devin) < notifications@github.com> wrote:
This is roughly what I mean. I did this from my phone, so it is a little sloppy.
[image: tmp_31039-closing slash-595597593] https://cloud.githubusercontent.com/assets/6258309/14491055/91f3ebfc-0144-11e6-817f-c5b2bedf21e2.png
— You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/tonsky/FiraCode/issues/115#issuecomment-209365721
OK.
/>
looks very bad, hard to read & feels forced. Since I see this often in HTML, I find the slash to be noisy anyhow in normal fonts, so I do appreciate the attempt. I'd prefer a version with the/
is smaller but with a space before>
. Let me know if you want a mockup.