tonsky / FiraCode

Free monospaced font with programming ligatures
SIL Open Font License 1.1
76.7k stars 3.09k forks source link

Issues with Powerline glyphs #1249

Open benlavender opened 3 years ago

benlavender commented 3 years ago

Seems I cannot get the glyphs loaded with FiraCode as they show with the usual boxes. Are these supported with FiraCode?

For example:

prompt themes

tonsky commented 3 years ago

Can you also post the glyphs themselves as a text?

wopian commented 3 years ago

Cascadia Mono/Code PL is mentioned as the powerline glyph font in https://docs.microsoft.com/en-us/windows/terminal/tutorials/powerline-setup

Has an extended set from the ones provided in Fira Code.

image



image



Edit: there also appears to a stypo variant of all of these glyphs that resizes the glyphs fit to the ascender height like in Fira Code. By default all of these extend a bit over the ascender in Cascadia PL

E0B0 ![image](https://user-images.githubusercontent.com/3440094/120926023-0f2df000-c6d3-11eb-9b86-df5a40552f11.png)
E0B0.stypo ![image](https://user-images.githubusercontent.com/3440094/120926041-1fde6600-c6d3-11eb-9605-4c22c30395d2.png)
E0B0 (Fira Code) ![image](https://user-images.githubusercontent.com/3440094/120926078-5caa5d00-c6d3-11eb-8558-5b7f542dcb7a.png)
wopian commented 3 years ago

Edit: Appears only the curved glyphs used in the theme is supplied by Cascadia Code PL.

The glyphs in the gmay theme for oh-my-posh are:

image

(os logo - one of these code points), (folder icon), (node.js logo) and (a running person/exit sign)

RubenVerg commented 3 years ago

Those come from Powerline Extra Symbols (which Cascadia Code supports) and NerdFonts patches (which I think aren't supported by default, but I'm not sure). The Fira Code Nerd Font patch is outdated, but they provide a tool to patch the font yourself. You can try that.


From: James Harris @.> Sent: Sunday, June 6, 2021 3:39:22 PM To: tonsky/FiraCode @.> Cc: Subscribed @.***> Subject: Re: [tonsky/FiraCode] Issues with Powerline glyphs (#1249)

The glyphs in the gmay OhMyPosh themehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJanDeDobbeleer%2Foh-my-posh%2Fblob%2Fmain%2Fthemes%2Fgmay.omp.json&data=04%7C01%7C%7Cde71cc646642412ec8d008d928f07ef2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637585835647827847%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=mGhPoGq5p7TQEW2SN3g%2B%2FiOCRDMTlD5vUZpsAeqLvv0%3D&reserved=0 are:

[image]https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F3440094%2F120926436-c70fcd00-c6d4-11eb-8295-51baee52c041.png&data=04%7C01%7C%7Cde71cc646642412ec8d008d928f07ef2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637585835647837841%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Zq064H0FuVD4O7Fpt8TtijK3hXdoORnTNyDV1kCCHxQ%3D&reserved=0

 (ubuntu logo?),  (folder icon),  (node.js logo) and ﰌ (a running person/exit sign)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftonsky%2FFiraCode%2Fissues%2F1249%23issuecomment-855401248&data=04%7C01%7C%7Cde71cc646642412ec8d008d928f07ef2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637585835647837841%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2Bq15MeLAohfJnCtGvu5Hq23yNsBPfgiEVYAYsatIT44%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMRJI3D37U7UOQTJITWL2U3TRN3AVANCNFSM46F37QIA&data=04%7C01%7C%7Cde71cc646642412ec8d008d928f07ef2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637585835647847835%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=R9Por5EJ9%2FPfwVjaLwPiBxm8Fadl%2FUFNUHp6grD6HAM%3D&reserved=0.

tonsky commented 3 years ago

Thanks! I’ll take a look

benlavender commented 3 years ago

Thanks for the replies, I'm not really clued up fonts so glad some others jumped in...