Add option to {de}activate the ?.

tonsky / FiraCode

Free monospaced font with programming ligatures

SIL Open Font License 1.1

77k stars 3.09k forks source link

Add option to {de}activate the ?. #1365

Open GrayJack opened 2 years ago

GrayJack commented 2 years ago

In Rust it's pretty common to have a question mark followed by a dot and the ligature:

makes the ligature unaligned with the rest of the code
makes the highlight fail on some editors

Fira Code (Ligatures)

Fira Mono (No ligatures)

tonsky commented 2 years ago

I am not sure what are you saying. ?. shouldn’t be grouped?

GrayJack commented 2 years ago

Yes, @tonsky that is correct

jearmstrong21 commented 2 years ago

For non-rustaceans: this is something like combining the ). in foo().bar

tonsky commented 2 years ago

Oh I see. I only saw it in Kotlin, and in Kotlin it’s a single operator, not ? and . combined. Makes sense to make a stylistic set then, thanks!

mon-jai commented 2 years ago

It would be better to be enabled by default.

?. is the optional chaining operator in JavaScript and it is popular among JavaScript developers.

GrayJack commented 2 years ago

For me personally, doesn't make a difference what is the default, as long as it is possible to toggle it. So as long most people are happy with the default, it works for me