tonsky / FiraCode

Free monospaced font with programming ligatures
SIL Open Font License 1.1
77.26k stars 3.1k forks source link

Bold double underscore "__" is not as thick as single underscore #322

Open joffrey-bion opened 7 years ago

joffrey-bion commented 7 years ago

The double underscore ligature in bold doesn't seem to be bold. We can see the difference in comparison to the single underscore:

image

tonsky commented 7 years ago

Interesting! Bold version has correct width in the font. What editor/OS are you on?

On Fri, Dec 2, 2016 at 4:40 PM Joffrey Bion notifications@github.com wrote:

The double underscore ligature in bold doesn't seem to be bold. We can see the difference in comparison to the single underscore:

[image: image] https://cloud.githubusercontent.com/assets/1913296/20842034/5317223a-b8b6-11e6-96cf-a60cad57a28d.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tonsky/FiraCode/issues/322, or mute the thread https://github.com/notifications/unsubscribe-auth/AARabGiG_6n-PYSm9bEodGgYjDEeiIEFks5rEEoEgaJpZM4LCvyO .

joffrey-bion commented 7 years ago

Sorry for the delay, and thanks for your interest! I'm using IntelliJ IDEA's editor on Windows 7, with Fira Code in size 12pt and line spacing 1.0 (unmodified).

IntelliJ IDEA 2016.3.1 EAP Build #IU-163.9166.7, built on November 29, 2016 JRE: 1.8.0_112-release-b585 amd64 JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o

Also, I wonder what is the rationale behind this ligature in the first place. Some fonts use full character width for underscore, so that the continuous effect is there without any ligature. Why did you do it this way?