search

tonsky / FiraCode

Free monospaced font with programming ligatures
SIL Open Font License 1.1
77.05k stars 3.1k forks source link

Add fl/fi ligatures #795

Closed sahil48 closed 5 years ago

sahil48 commented 5 years ago

Right now it feels that there is too little spacing between the f and l characters when they are next to each other. I feel that the font would look better if they would be replaced with an fl ligature, or the top half-serif on the l could be shortened.

image

bytemain commented 5 years ago

image It made me very uncomfortable... feel bad.

awmottaz commented 5 years ago

I agree, not a big fan of how this turned out

sahil48 commented 5 years ago

Referring to the initial example, perhaps instead, the fl ligature could be created where there is more separation between the top stem/serif of the "f" and "l" rather than fusing them together.

Avi-D-coder commented 5 years ago

Fira Mono does not have these ligatures, if we must have them can they at least be consistent with Fira sans?

Currently they are jarring. Where as I hardly notice Fira sans fl and fj ligatures.

adah1972 commented 4 years ago

I agree with many commenters that these ligatures look pretty bad. I would advocate these changes should be reverted.

I do not think such ligatures should be enabled in a monospace font.

Avi-D-coder commented 4 years ago

I removed these ligatures and built otf

adah1972 commented 4 years ago

@Avi-D-coder Thanks. Did you make a pull request to this master project?

Arcitec commented 4 years ago

@tonsky Hi Nikita. Have you seen the discussion here? Many people (including me) strongly dislike these ligatures. They look jarring in a monospace font (everything is spaced out, but then suddenly f and l are fused!?). And worst of all, Tl with the new ligatures looks like π (pi). Wtf. Hehe. Please make these ligatures optional via ss setting... :-( The first feeling after installing the font today was "wow this font is beautiful, but... ewwww that ligature... can I turn it off somehow?"... Sad that I can't. :-( I'd much prefer the original in the OP's post above. :-S

Edit: Ehm... my love for Fira Code was short lived (about 15 minutes). The "Fl / Tl" was so painful to look at that I started looking for other fonts. Found IBM Plex Mono at https://www.ibm.com/plex/ (https://github.com/IBM/plex/releases) which was designed by IBM for their programmers, to be looked at day in and day out. They used pixel-precise angles to ensure sharp rendering. It is incredibly crisp, extremely easy to read, and expertly designed. The italics are a work of art (which my editor uses for comments) and are based on the famous 1960s IBM Selectric Typewriter, which gives it a very cool and unique design. There are no ligatures for stuff like !=, but the font puts those characters super close to each other (which looks great), so I don't miss ligatures. There is a modded version at https://github.com/IBM/plex/issues/63#issuecomment-552940293 which adds ligatures if someone really wants that in the IBM Plex font... :-) Anyway, if Fira Code improves the "Pi"-like "Tl" situation, I will revisit this font too, because it's a nice font... but I'm off to IBM land for now...