search

tonsky / FiraCode

Free monospaced font with programming ligatures
SIL Open Font License 1.1
76.08k stars 3.07k forks source link

`\/` might appear in regexp #848

Open tonsky opened 4 years ago

tonsky commented 4 years ago

Using VS Code: image

The language mode is set to JavaScript; interestingly it seems to work as expected with it set to plain text.

I now believe that it may be a bug in VS Code in how ligatures interact with syntax highlighting. @tonsky, should I open a new issue here? Can you confirm that it is indeed an issue with the editor?

Originally posted by @nunocastromartins in https://github.com/tonsky/FiraCode/issues/728#issuecomment-533191852

tonsky commented 4 years ago

LOL I never thought about that. Indeed because of syntax highlighting it thinks \/ is a standalone entity. Gotta roll that back then

YarnSphere commented 4 years ago

I think it should be safe if it triggers only when surrounded by spaces, and not if it is a standalone entity, if that makes sense.

tonsky commented 4 years ago

Maybe. Still feel there might be false positives...

j-f1 commented 4 years ago

Maybe it should be in a stylistic set?

tonsky commented 4 years ago

Maybe :)

doughsay commented 3 years ago

DeepinScreenshot_select-area_20210217150000

So I just ran into this too, and it confused me for a second... this is happening in vscode in Elixir. Do we have a way to fix this yet?

RubenVerg commented 3 years ago

I'm always going to say the same thing here: a (escaped) slash character is a single token in my mind. splitting would mean more time to understand the code. It's the same reason why I thing (.) should ligate to a circled dot: capturing a character is a token to me

From: Chris Dosé notifications@github.com Sent: Thursday, February 18, 2021 12:01:53 AM To: tonsky/FiraCode FiraCode@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [tonsky/FiraCode] \/ might appear in regexp (#848)

[DeepinScreenshot_select-area_20210217150000]https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F221693%2F108279039-d1f81f00-7130-11eb-94eb-667709f4c301.png&data=04%7C01%7C%7C089793c4778c4a301afa08d8d398048e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637491997151355980%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2BxDQKdHipRMlZZRUI88rX17wjsHZxwVfrl8Gtn0JPr0%3D&reserved=0

So I just ran into this too, and it confused me for a second... this is happening in vscode in Elixir. Do we have a way to fix this yet?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftonsky%2FFiraCode%2Fissues%2F848%23issuecomment-780911176&data=04%7C01%7C%7C089793c4778c4a301afa08d8d398048e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637491997151365976%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=NzcQMCtpxzYMYZNHIBr0Go%2FofVN7UWL%2BLmx9F6vRugQ%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMRJI3AQ5GULT7NREZTH4ZDS7RDGDANCNFSM4IZKCZCQ&data=04%7C01%7C%7C089793c4778c4a301afa08d8d398048e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637491997151365976%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=E3c8%2F9trJZcXNFYO63MKXSWOY0tN6D3Oqv52PKxvbpc%3D&reserved=0.