Data retracted incorrectly in CLJS

[ash14]

It seems that the implementation of value-compare using hashcodes can lead to some very surprising behaviour:

Compare CLJ:

(let [conn (d/create-conn)]
  (d/transact! conn [{:user/age 42.5}])
  (:tx-data (d/transact! conn [[:db/retract 1 :user/age 42]])) ; => []
  (d/touch (d/entity (d/db conn) 1))) ; => {:user/age 42.5, :db/id 1}

With CLJS:

(let [conn (d/create-conn)]
  (d/transact! conn [{:user/age 42.5}])
  (:tx-data (d/transact! conn [[:db/retract 1 :user/age 42]])) ; => [#datascript/Datom[1 :user/age 42.5 536870914 false]]
  (d/touch (d/entity (d/db conn) 1))) ; => {:db/id 1}

In this case 42 should not be considered equal to 42.5

[tonsky]

Thank you, that’s nasty. Fixed in 1.2.7

[ash14]

Thanks for the quick response. Confirmed fixed when using 1.2.7 from clojars but the change isn't in this repo? https://github.com/tonsky/datascript/compare/1.2.6...1.2.7

[tonsky]

My bad. Looks like I deployed from a local copy and forgot to commit. Republished properly as 1.2.8