Implement the interpolate protocol for strings without modifying String.prototype

tonsky / tongue

Do-it-yourself i18n library for Clojure/Script

Eclipse Public License 1.0

307 stars 19 forks source link

Implement the interpolate protocol for strings without modifying String.prototype #29

Closed cjohansen closed 2 years ago

cjohansen commented 2 years ago

I'm sorry, but my previous PR extended a protocol to js/String in ClojureScript. Turns out that that effectively modifies String.prototype. Using the symbolic value string as target for extend-type is the safe way to implement protocols to built-ins in ClojureScript.

tonsky commented 2 years ago

Thanks! Pushed 0.4.1

cjohansen commented 2 years ago

🙏