search

tonsky / tongue

Do-it-yourself i18n library for Clojure/Script
Eclipse Public License 1.0
310 stars 20 forks source link

Warning about `tongue.core/parse-long` shadowing clojure.core output when using Clojure 1.11.0 #35

Closed stevejmp closed 2 years ago

stevejmp commented 2 years ago

Expected

In a project using Tongue, bumping the Clojure dep to the recent release, 1.11.0, should output no new warnings or exceptions when run.

Actual

WARNING: parse-long already refers to: #'clojure.core/parse-long in namespace: tongue.core, being replaced by: #'tongue.core/parse-long

Steps to Reproduce

  1. In a project using Tongue, bump the Clojure dep to 1.11.0
  2. Run the project from a terminal
  3. View the output

Versions

Tongue 0.4.3 (2021-12-10) Clojure 1.11.0 Java 11.0.14 Leiningen 2.9.8

More Info

A new parse-long function was added to clojure.core in 1.11.0. The tongue.core/parse-long function now shadows this, resulting in the warning.

Workaround until Tongue requires Clojure 1.11: add (:refer-clojure :exclude [parse-long]) to the ns declaration in tongue.core.

PR incoming.