search

tonsky / tongue

Do-it-yourself i18n library for Clojure/Script
Eclipse Public License 1.0
307 stars 19 forks source link

upgrade clj/cljs version and remove parse-long warning. #38

Open tlonist-sang opened 6 months ago

tlonist-sang commented 6 months ago 
; Warnings in Library Code:
;  parse-long already refers to: cljs.core/parse-long being replaced by: no.en.core/parse-long
;  parse-double already refers to: cljs.core/parse-double being replaced by: no.en.core/parse-double

Now that parse-long is inherently implemented in both clj/cljs (1.11, 1.11.50 onwards, repectively), the parse-long function need not be excluded. After upgrading clojure version, 

(:refer-clojure :exclude [parse-long])

This line should be removed.

tlonist-sang commented 6 months ago

ah, this was already mentioned in #36. But the warnings persist with 0.4.4? Do you plan to bump clojure/clojurescript to ver.11?

tonsky commented 6 months ago

I don’t see a warning neither in Clojure nor CLJS. It is set up this way so it would work with both old and new versions of Clojure. You suggest to change it so it only works with new ones. Why? What will we be getting?