search

tontof / kriss_feed

A simple and smart (or stupid) feed reader
279 stars 52 forks source link

PHP 8.0 support #420

Closed doc75 closed 3 years ago

doc75 commented 3 years ago

I tried to run KrissFeed with PHP 8.0, but failed with an error message related to undefined function get_magic_quotes_gpc.

I checked in the repo and realised that the fixes to get PHP 7.4 working (and that should allow also the code to work with 8.0) are not yet in index.php. Do you plan to re-generate an updated version of index.php (I could rebuild it myself, but I am relying on the stable version you provide usually ;-) ) ?

Thanks for this great software.

doc75 commented 3 years ago

Perhaps I should use src/index.php instead. But I am not sure what is the difference between index.php and src/index.php in term of intent (dev vs. stable ?).

src/index.php seems to work fine with php 8.0 after some tests.

tontof commented 3 years ago

You're right, src/index.php is the future version and correspond to the dev one while the index.php is the last released version. That's great it works with PHP 8.0 I don't have this version yet and did not test myself. Maybe I should update index.php so that it corresponds to the last dev version as I did not plan modification for now. Thanks for your feedback!

doc75 commented 3 years ago

Issue solved by using the 8.11 version