search

tontof / kriss_feed

A simple and smart (or stupid) feed reader
280 stars 54 forks source link

feat(favicon): Only provides domain when querying favicons #432

Closed thican closed 2 years ago

thican commented 2 years ago

And also switches to DuckDuckGo’s service.

Signed-off-by: Thibaud CANALE thican@thican.net

tontof commented 2 years ago

Sorry for this late reply, I was busy these days. Thanks for the PR, I thought it is merged https://github.com/tontof/kriss_feed/commit/6632730bb1abc0d506885e53c0bbe907e3558e55 but does not appear to be correctly merged. I've just removed your main index.php as it should not be modified directly. This file is generated by src/make.php when I publish a new stable version.

thican commented 2 years ago

Hello, Thanks for your answer. I didn’t know about file index.php, it’s still look out of date. Too bad my GPG signature is not present anymore. About this MR, yes something’s odd, it didn’t seem closed because it looks like you didn’t use the same branch. I guess we need to close it manually then. Thanks again for your work.