search

tony-o / raku-fez

This project is for 'fez', raku's cool new shiny dist uploader & manager. If you're a module author you should definitely be using this sweet thang. ;;;;;;;;;;;;;; This project and the underlying infrastructure is supported out of my own pocket and through donations. If you'd like to donate please check here: https://www.patreon.com/oynot
Artistic License 2.0
20 stars 12 forks source link

`fez checkbuild` doesn't test the same things as `checkbuild` run via `fez upload` #73

Closed masukomi closed 1 year ago

masukomi commented 1 year ago

This builds on #72

That's about the problem of macOS adding invisible files that we don't want. However, it revealed the fact that fez checkbuild returns a 👍🏻 when you run it directly and a 👎🏻 when you run it via fez upload. This, then revealed a branch in checkbuilds code that means it's not testing the same thing in the same way.

checkbuild should run identical tests and provide identical answers regardless of if it is run directly, or via fez upload Otherwise we can never completely trust its output.

tony-o commented 1 year ago

The only thing different I'm finding is that the different logic branch is handling an auth mismatch that's off by default, is this what you're referring to?

masukomi commented 1 year ago

i was referring to the fact that checkbuild wasn't reporting the error resulting from AppleDouble files in Issue #72 , but upload did. If checkbuild was actually testing all the same potential issues it would have reported the error too.

tony-o commented 1 year ago

checkbuild is using the local repo and not creating a dist. i don't think creating a dist file is appropriate for a cursory checkbuild. if there is a way to know whether the file is an apple double file with certainty then checkbuild may be able to ignore it but i can't find much information on how to discern apple double files from just regular files named ._..., do you have more information on this?