tony-o / raku-fez

This project is for 'fez', raku's cool new shiny dist uploader & manager. If you're a module author you should definitely be using this sweet thang. ;;;;;;;;;;;;;; This project and the underlying infrastructure is supported out of my own pocket and through donations. If you'd like to donate please check here: https://www.patreon.com/oynot
Artistic License 2.0
20 stars 12 forks source link

fez hangs during upload - `--unattended` flag is not honored #83

Closed melezhik closed 1 year ago

melezhik commented 1 year ago

During upload operation fez hangs. Full log including fez version and other details here - https://ci.sparrowhub.io/report/2843

HTH

tony-o commented 1 year ago

Can you point me to the repo this is happening with? (Or supply your handmade tarball?)

melezhik commented 1 year ago

https://github.com/melezhik/SparrowCI

melezhik commented 1 year ago

And … I install fez from https://github.com/tony-o/raku-fez.git , maybe not very good idea …

tony-o commented 1 year ago

@melezhik which version does it report from fez -v ?

melezhik commented 1 year ago

20:13:55 :: ===> Installing: fez:ver<40>:auth:api<0> 20:14:04 :: 20:14:04 :: 1 bin/ script [fez] installed to: 20:14:04 :: /home/worker/.raku/bin 20:14:05 :: cleaning /var/.sparrowdo/env/test/.sparrowdo/source/.tom/.cache ... 20:14:05 :: >>= fez version: 40 20:14:06 :: >>= Looking in "sdist/WsmUK7ED.tar.gz" for META6.json 20:14:08 :: >>= meta looks OK 20:14:08 :: >>= meta looks OK 20:14:08 :: >>= SparrowCI:ver<0.0.11>:auth looks OK

tony-o commented 1 year ago

@melezhik is this running in the busybox container?

melezhik commented 1 year ago

No, this is Debian

On Sun, Feb 5, 2023 at 3:20 PM tony-o @.***> wrote:

@melezhik https://github.com/melezhik is this running in the busybox container?

— Reply to this email directly, view it on GitHub https://github.com/tony-o/raku-fez/issues/83#issuecomment-1418268089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHRHSJMJZZU4HQG5DQ43LTWWAKSVANCNFSM6AAAAAAUPXAGJQ . You are receiving this because you were mentioned.Message ID: @.***>

melezhik commented 1 year ago

Ok, this is not a tar issue, I've run command manually from container, and it seems that --unattended flag is not honored:

worker@ca60ead8977c:/var/.sparrowdo/env/test/.sparrowdo/source$ cat ~/.fez-config.json 
 {
    "groups":[],"un":"melezhik","key":"**********",
    "bundlers": ["Fez::Util::Pax"]
 }
worker@ca60ead8977c:/var/.sparrowdo/env/test/.sparrowdo/source$ fez upload --u^C
worker@ca60ead8977c:/var/.sparrowdo/env/test/.sparrowdo/source$ fez upload --unattended
>>= Looking in "sdist/Yq0ijUw3.tar.gz" for META6.json
>>= meta<provides> looks OK
>>= meta<resources> looks OK
>>= SparrowCI:ver<0.0.11>:auth<zef:melezhik> looks OK
=<< Key is expired, please login:
>>= Username: ^C
tony-o commented 1 year ago

@melezhik ahhh okay, i'm working on this issue - this is more difficult and I need a new pattern to remove universal flags in MAIN

melezhik commented 1 year ago

@tony-o sure, no rush

patrickbkr commented 1 year ago

IIU this issue correctly, it's the server that rejected the request because the "Key is expired". There isn't much an --unattended flag could do about that. Right?

melezhik commented 1 year ago

When runs with unattended flag fez should not hang if a user token is expired, but exit immediately with proper exit code. Instead of this ( and this is the essence of the issue) fez waits for a login and password to regenerate token.

“Killed” line in the end of report simply means that a docker container is terminated by SparrowCI orchestrator after some timeout …

Expected behavior for fez when runs with unattended flag is to exit immediately with none zero exit code ( and helpful message in stderr) in case of any errors …

HTH

tony-o commented 1 year ago

@patrickbkr if the key expired then fez will prompt for a username and password

This is fixed in the dist branch -