search

tony-o / raku-fez

This project is for 'fez', raku's cool new shiny dist uploader & manager. If you're a module author you should definitely be using this sweet thang. ;;;;;;;;;;;;;; This project and the underlying infrastructure is supported out of my own pocket and through donations. If you'd like to donate please check here: https://www.patreon.com/oynot
Artistic License 2.0
20 stars 12 forks source link

Is require considered in review? #94

Closed finanalyst closed 1 year ago

finanalyst commented 1 year ago

I just ran fez review on an old module for the first time. Previously I used fez checkbuild.

fez v
>>= fez version: 51

Some problems picked up that I needed to resolve. But this was unexpected:

>>=   in meta but unexpected:
         Template::Mustache

However using rak 'Template::Mustache' . yields

169:require Template::Mustache;
185:$!engine = Template::Mustache.new without $!engine;

This indicates that fez review picks up use pragmas, but not require.

tony-o commented 1 year ago

I'll add this to the next release -

tony-o commented 1 year ago

@finanalyst i'm going to disable the *depends|provides checks in fez for the time being, without rakuast being fully implemented it's too difficult to tell what's provided/needed by the dist.

Will be in v52