search

tony-o / raku-fez

This project is for 'fez', raku's cool new shiny dist uploader & manager. If you're a module author you should definitely be using this sweet thang. ;;;;;;;;;;;;;; This project and the underlying infrastructure is supported out of my own pocket and through donations. If you'd like to donate please check here: https://www.patreon.com/oynot
Artistic License 2.0
20 stars 12 forks source link

Review flagging as dependent modules declared as provided #95

Closed finanalyst closed 1 year ago

finanalyst commented 1 year ago

My Raku::Pod::Render module used to pass fez checkbuild. I made a minor change. Locally fez checkbuild passed, but after fez upload, which gave a positive message, I got an email saying there was a Meta error. But no information about the error. So I upgraded fez. fez checkbuild no longer is accepted as a valid option. (Maybe a deprecation message at least??) But now I cannot upload a working Distribution!!!

Note that I have structured this repo as a Distribution rather than a Module, as described in the Documentation.

Among errors (????), I find that Modules in the distribution listed as provided are now missing dependents. Eg.

>>= Depends not ok
>>=   not in meta:
         RenderPod::Templating
         RenderPod::Highlighting
         RenderPod::Exceptions

But also

>>= Provides not ok
....
>>=   in meta but unexpected:
         RenderPod::Test-Templates
         RenderPod::Templating
         RenderPod::Highlighting
         RenderPod::Exceptions
tony-o commented 1 year ago

@finanalyst there was a checkbuild deprecation message but five versions have happened since. Maybe I should leave it in for future releases.

I'll take a look at making this a little cleaner and providing better info. One thing it doesn't do is check whether RenderPod in META provides the missing stuff. This is a bug, it shouldn't be both errors and will fix for next release.

finanalyst commented 1 year ago

@tony-o Thanks. Its possible that I didn't upgrade fez for quite a while, until it stopped registering the module. So quite possible I simply didnt have a fez with the deprecation notice. Fez just worked so well I didnt need to fix anything.

I just looked at the README. It still shows checkbuild but not review. Distribution README needs some TLC

tony-o commented 1 year ago

@finanalyst i'm going to disable the *depends|provides checks in fez for the time being, without rakuast being fully implemented it's too difficult to tell what's provided/needed by the dist.

Will be in v52 and will update README

tony-o commented 1 year ago

This is fixed in v52 (disabled until Raku AST), please upgrade and confirm

finanalyst commented 1 year ago

I have been able to upload my distribution. Thank you