tony-o / raku-fez

This project is for 'fez', raku's cool new shiny dist uploader & manager. If you're a module author you should definitely be using this sweet thang. ;;;;;;;;;;;;;; This project and the underlying infrastructure is supported out of my own pocket and through donations. If you'd like to donate please check here: https://www.patreon.com/oynot
Artistic License 2.0
20 stars 12 forks source link

depends issues #98

Closed pmqs closed 1 year ago

pmqs commented 1 year ago

Testing Archive::SimpleZip with fez review I get the following issues

>>= Depends not ok
>>=   not in meta:
         File::Find
>>=   in meta but unexpected:
         Compress::Zlib

Problems

  1. File::Find is present in pod documentation but isn't actually needed.
  2. Compress::Zlib is actually needed

In lib/Archive/SimpleZip.rakumod I have this

unit module Archive::SimpleZip:ver<0.6.0>:auth<zef:pmqs>;

need Compress::Zlib;
tony-o commented 1 year ago

This is fixed in v52 (disabled until Raku AST), please upgrade and confirm

pmqs commented 1 year ago

This is fixed in v52 (disabled until Raku AST), please upgrade and confirm

Before

$ fez v
>>= fez version: 51
$ fez review

>>= Bundle manifest:
       Changes
       lib/Archive/SimpleZip.rakumod
       lib/Archive/SimpleZip/Headers.rakumod
       lib/Archive/SimpleZip/Utils.rakumod
       LICENSE
       META6.json
       mkdocs
       README.md
       t/001-use.t
       t/002-basic.t
       t/004-canonical.t
       t/lib
       t/meta.t
       t/test.zip
       t/util/zipdetails
       t/ZipTest.rakumod
>>= Build depends ok
>>= Depends not ok
>>=   not in meta:
         File::Find
>>=   in meta but unexpected:
         Compress::Zlib::Raw
         Compress::Zlib
>>= Provides ok
>>= Resources ok
>>= Test depends ok

upgrade fezU

$ zef upgrade fez
===> Searching for: fez
The following distributions will be upgraded: fez:ver<52>:auth<zef:tony-o>:api<0>
===> Updating: fez:ver<52>:auth<zef:tony-o>:api<0>
===> Searching for missing dependencies: libz:from<native>
Use of Nil in string context
  in block  at /home/paul/.rakubrew/versions/moar-2023.04/share/perl6/site/sources/020B1DCFD2D1C1C1948036C328066D9F71CCE234 (Zef::Repository) line 143
Use of Nil in string context
  in block  at /home/paul/.rakubrew/versions/moar-2023.04/share/perl6/site/sources/020B1DCFD2D1C1C1948036C328066D9F71CCE234 (Zef::Repository) line 143
Use of Nil in string context
  in block  at /home/paul/.rakubrew/versions/moar-2023.04/share/perl6/site/sources/020B1DCFD2D1C1C1948036C328066D9F71CCE234 (Zef::Repository) line 143
===> Failed to find dependencies: libz:from<native>
Failed to resolve some missing dependencies (use e.g. --exclude="libz" to skip)
!!!> Failed upgrading *all* modules

Hmm, that didn';t work so well. No idea if that is zef or fez. Lets try trhe suggested workaround

$ zef upgrade --exclude=libz fez
===> Searching for: fez
The following distributions will be upgraded: fez:ver<52>:auth<zef:tony-o>:api<0>
===> Updating: fez:ver<52>:auth<zef:tony-o>:api<0>
===> Testing: fez:ver<52>:auth<zef:tony-o>:api<0>
===> Testing [OK] for fez:ver<52>:auth<zef:tony-o>:api<0>
===> Installing: fez:ver<52>:auth<zef:tony-o>:api<0>

1 bin/ script [fez] installed to:
/home/paul/.rakubrew/versions/moar-2023.04/share/perl6/site/bin

That's better.

Now try fez review again

$ fez review
>>= Bundle manifest:
       Changes
       lib/Archive/SimpleZip.rakumod
       lib/Archive/SimpleZip/Headers.rakumod
       lib/Archive/SimpleZip/Utils.rakumod
       LICENSE
       META6.json
       mkdocs
       README.md
       t/001-use.t
       t/002-basic.t
       t/004-canonical.t
       t/lib
       t/meta.t
       t/test.zip
       t/util/zipdetails
       t/ZipTest.rakumod
>>= Resources ok

Perfect!