tony-xlh / vision-camera-dynamsoft-label-recognizer

React Native Vision Camera Frame Processor Plugin of Dynamsoft Label Recognizer
MIT License
29 stars 4 forks source link

Not working with vision camera v4 #6

Open Vadko opened 3 weeks ago

Vadko commented 3 weeks ago

I've installed library within my own project and there were 2 issues on ios (not tested android):

  1. Library doesn't recognize mrz labels
  2. App crashes in debug mode when trying to read data from MRZ because of memory leak

Then I've tried to clone example repo and result was the same. I assume that something is wrong with library specifically for v4, because v3 example worked perfectly in my case.

tony-xlh commented 3 weeks ago

I think this is related to two issues in v4:

  1. The overlay is not accurate. You have to use skia to draw the camera preview: https://github.com/mrousavy/react-native-vision-camera/issues/3231
  2. runAsync has a memory problem: https://github.com/mrousavy/react-native-vision-camera/issues/3202

You can try this demo to see if the cropped image is correct: https://github.com/tony-xlh/react-native-id-card-scanner

Vadko commented 2 weeks ago

Thanks for sharing this example - it works perfectly fine. However, when trying to put it together with document-normalizer plugin you created - it doesnt work because of DynamsoftCore version difference. Is it something that could be changed?

xulihang commented 2 weeks ago

I have to update the label recognizer plugin to make it compatibile with the document normalizer plugin.

xulihang commented 4 hours ago

I've updated the two plugins to make them work together.