cannot use on Solaris 10, timeradd() undef

[drook]

While it's building properly on Solaris 10, and even it's capable of sending stats, when using pinba-enabled PHP code php will complain about undefined symbol timersub().

This code fixes it:

#ifndef timersub
#define timersub(tvp, uvp, vvp)                                 \
        do                                                              \
        {                                                               \
                (vvp)->tv_sec = (tvp)->tv_sec - (uvp)->tv_sec;          \
                (vvp)->tv_usec = (tvp)->tv_usec - (uvp)->tv_usec;       \
                if ((vvp)->tv_usec < 0)                                 \
                {                                                       \
                        (vvp)->tv_sec--;                                \
                        (vvp)->tv_usec += 1000000;                      \
                }                                                       \
        } while (0)
#endif

[tony2001]

Huh? What's the difference between this issue and issue #9, which is already fixed in Git?

[drook]

Lol. I should probably take more sleep or drink more coffee. :) I copypasted the wrong piece of code, then wrote the subject accordingly. :) This is really about another macro - timeradd():

#ifndef timeradd
#define timeradd(tvp, uvp, vvp)                                         \
        do {                                                            \
                (vvp)->tv_sec = (tvp)->tv_sec + (uvp)->tv_sec;          \
                (vvp)->tv_usec = (tvp)->tv_usec + (uvp)->tv_usec;       \
                if ((vvp)->tv_usec >= 1000000) {                        \
                        (vvp)->tv_sec++;                                \
                        (vvp)->tv_usec -= 1000000;                      \
                }                                                       \
        } while (0)
#endif

Sorry for this. :)

[tony2001]

Ah, ok. Solaris is WEIRD.