The PinbaClient class incorrect work with request_time variable

[aparkhomenko]

Hello,

When I try to use:

php -r '$pc = new PinbaClient(array(ini_get("pinba.server"))); $pc->setRequestTime(0.1);'

I've got the warning Warning: PinbaClient::setRequestTime(): request_time cannot be less than zero in Command line code on line 1

That's because you use: SET_METHOD_NUM(setRequestTime, request_time, float, "d");

As I know php variables use type double but you compare with type float in that macros.

[aparkhomenko]

I did the pull request for this problem: https://github.com/tony2001/pinba_extension/pull/21

[Koc]

@tony2001 looks like this issue can be closed...

[tony2001]

Weird, I didn't get a notification for this issue. Sure, it can be closed, if the patch fixes it.