search

tony2001 / pinba_extension

Pinba PHP extension
http://pinba.org
GNU Lesser General Public License v2.1
84 stars 22 forks source link

PHP7.3 support #37

Closed yuklia closed 4 years ago

yuklia commented 4 years ago

Hi, thanks a lot for Pinba! Really great tool for php-monitoring 👍 But there is an issue with php:7.3-fpm version (see stack trace)

/usr/src/php/ext/pinba/pinba.c: In function 'zif_pinba_timer_start':
/usr/src/php/ext/pinba/pinba.c:1295:19: error: lvalue required as increment operand
  GC_REFCOUNT(rsrc)++;
                   ^~
/usr/src/php/ext/pinba/pinba.c: In function 'zif_pinba_timer_add':
/usr/src/php/ext/pinba/pinba.c:1354:19: error: lvalue required as increment operand
  GC_REFCOUNT(rsrc)++;
                   ^~
/usr/src/php/ext/pinba/pinba.c: In function 'zif_pinba_timers_get':
/usr/src/php/ext/pinba/pinba.c:1811:21: error: lvalue required as increment operand
    GC_REFCOUNT(rsrc)++;
                     ^~
make: *** [Makefile:195: pinba.lo] Error 1

wanna point out: php:7.2-fpm works just fine

tony2001 commented 4 years ago

Actually, it's been fixed for long time already, but I haven't made a release for a while. Please try version 1.1.2 I've released several minutes ago.

yuklia commented 4 years ago

@tony2001 super cool and very fast! It works. Thanks a lot !!!

tony2001 commented 4 years ago

Great, thanks for checking it out.